Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 481b9606 authored by Joe Perches's avatar Joe Perches Committed by John W. Linville
Browse files

rtlwifi: add CONFIG_RTLWIFI_DEBUG to remove all of the debug logging code 



It does seem odd though to have a DBG_EMERG and not always
emit it.

What might also be useful for any embedded use is to add
CONFIG_RTLWIFI_DEBUG to conditionally remove all of the
debug logging code to reduce the largish object size.

This reduces the object size by about 1/3 (250KB)
when CONFIG_RTLWIFI_DEBUG is not set.

$ size drivers/net/wireless/rtlwifi/built-in.o*
   text	   data	    bss	    dec	    hex	filename
 368722	  55333	  94224	 518279	  7e887	drivers/net/wireless/rtlwifi/built-in.o.new
 586904	  55333	 127216	 769453	  bbdad	drivers/net/wireless/rtlwifi/built-in.o.old

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent f56e7eb4

drivers/net/wireless/rtlwifi/Kconfig

+5 −0
Original line number Diff line number Diff line
@@ -49,6 +49,11 @@ config RTLWIFI 
	depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE

	default m



config RTLWIFI_DEBUG

	tristate "Additional debugging output"

	depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE

	default y



config RTL8192C_COMMON

	tristate

	depends on RTL8192CE || RTL8192CU

drivers/net/wireless/rtlwifi/debug.h

+34 −0
Original line number Diff line number Diff line
@@ -156,6 +156,8 @@ enum dbgp_flag_e { 
	DBGP_TYPE_MAX

};



#ifdef CONFIG_RTLWIFI_DEBUG



#define RT_ASSERT(_exp, fmt, ...)					\

do {									\

	if (!(_exp)) {							\
@@ -195,5 +197,37 @@ do { \ 
	}								\

} while (0)



#else



struct rtl_priv;



__printf(2, 3)

static inline void RT_ASSERT(int exp, const char *fmt, ...)

{

}



__printf(4, 5)

static inline void RT_TRACE(struct rtl_priv *rtlpriv,

			    int comp, int level,

			    const char *fmt, ...)

{

}



__printf(4, 5)

static inline void RTPRINT(struct rtl_priv *rtlpriv,

			   int dbgtype, int dbgflag,

			   const char *fmt, ...)

{

}



static inline void RT_PRINT_DATA(struct rtl_priv *rtlpriv,

				 int comp, int level,

				 const char *titlestring,

				 const void *hexdata, size_t hexdatalen)

{

}



#endif



void rtl_dbgp_flag_init(struct ieee80211_hw *hw);

#endif