Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 469a1cde authored by Vladimir Kondratiev's avatar Vladimir Kondratiev Committed by Ian Maund
Browse files

wil6210: fix free'd memory access in wil_if_free() 



In the wil_priv_deinit(), wdev->netdev is accessed, so free_netdev()
should not be called before mentioned call.

Set wdev->netdev to NULL Make sure no more attempts to use it.
It is used for debug printk if not NULL.

This fix kernel panic on module unload and in case error on probe;
if memory allocation debugging enabled.

Change-Id: I234993b93c50bb4df13f94f0a8ee1391daeca551
Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
Git-commit: 8fcfdeac97ee3ee8dd8e0e44b6a3b9d49b951bbd
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git


Signed-off-by: default avatarHamad Kadmany <hkadmany@codeaurora.org>
parent a52a126b

drivers/net/wireless/ath/wil6210/netdev.c

+5 −1
Original line number Diff line number Diff line
@@ -168,11 +168,15 @@ void *wil_if_alloc(struct device *dev, void __iomem *csr) 
void wil_if_free(struct wil6210_priv *wil)

{

	struct net_device *ndev = wil_to_ndev(wil);



	if (!ndev)

		return;



	free_netdev(ndev);

	wil_priv_deinit(wil);



	wil_to_ndev(wil) = NULL;

	free_netdev(ndev);



	wil_wdev_free(wil);

}