Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40cdd659 authored by Serban Constantinescu's avatar Serban Constantinescu Committed by Olav Haugan
Browse files

staging: android: binder: Add binder_copy_to_user() 



This patch adds binder_copy_to_user() to be used for copying binder
commands to user address space. This way we can abstract away the
copy_to_user() calls and add separate handling for the compat layer.

Change-Id: I6e0b4e5c1fc0828f1eb0bccbaf61ab740decaef5
Signed-off-by: default avatarSerban Constantinescu <serban.constantinescu@arm.com>
Git-commit: f5094abcf6c711120bbd0145d5454571dd845a73
Git-repo: git://linux-arm.org/linux-2.6-armdroid.git


Signed-off-by: default avatarOlav Haugan <ohaugan@codeaurora.org>
parent 72acba3b

drivers/staging/android/binder.c

+21 −18
Original line number Diff line number Diff line
@@ -2135,6 +2135,18 @@ static int binder_has_thread_work(struct binder_thread *thread) 
		(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN);

}



static int binder_copy_to_user(uint32_t cmd, void *parcel,

			       void __user **ptr, size_t size)

{

	if (put_user(cmd, (uint32_t __user *)*ptr))

		return -EFAULT;

	*ptr += sizeof(uint32_t);

	if (copy_to_user(*ptr, parcel, size))

		return -EFAULT;

	*ptr += size;

	return 0;

}



static int binder_thread_read(struct binder_proc *proc,

			      struct binder_thread *thread,

			      void  __user *buffer, size_t size,
@@ -2281,15 +2293,12 @@ retry: 
				node->has_weak_ref = 0;

			}

			if (cmd != BR_NOOP) {

				if (put_user(cmd, (uint32_t __user *)ptr))

					return -EFAULT;

				ptr += sizeof(uint32_t);

				if (put_user(node->ptr, (void * __user *)ptr))

					return -EFAULT;

				ptr += sizeof(void *);

				if (put_user(node->cookie, (void * __user *)ptr))

				struct binder_ptr_cookie tmp;



				tmp.ptr = node->ptr;

				tmp.cookie = node->cookie;

				if (binder_copy_to_user(cmd, &tmp, &ptr, sizeof(struct binder_ptr_cookie)))

					return -EFAULT;

				ptr += sizeof(void *);



				binder_stat_br(proc, thread, cmd);

				binder_debug(BINDER_DEBUG_USER_REFS,
@@ -2324,12 +2333,10 @@ retry: 
				cmd = BR_CLEAR_DEATH_NOTIFICATION_DONE;

			else

				cmd = BR_DEAD_BINDER;

			if (put_user(cmd, (uint32_t __user *)ptr))

				return -EFAULT;

			ptr += sizeof(uint32_t);

			if (put_user(death->cookie, (void * __user *)ptr))



			if (binder_copy_to_user(cmd, &death->cookie, &ptr, sizeof(void *)))

				return -EFAULT;

			ptr += sizeof(void *);



			binder_stat_br(proc, thread, cmd);

			binder_debug(BINDER_DEBUG_DEATH_NOTIFICATION,

				     "%d:%d %s %p\n",
@@ -2391,12 +2398,8 @@ retry: 
					ALIGN(t->buffer->data_size,

					    sizeof(void *));



		if (put_user(cmd, (uint32_t __user *)ptr))

		if (binder_copy_to_user(cmd, &tr, &ptr, sizeof(struct binder_transaction_data)))

			return -EFAULT;

		ptr += sizeof(uint32_t);

		if (copy_to_user(ptr, &tr, sizeof(tr)))

			return -EFAULT;

		ptr += sizeof(tr);



		trace_binder_transaction_received(t);

		binder_stat_br(proc, thread, cmd);