Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fe4caec authored by Scot Doyle's avatar Scot Doyle Committed by TARKZiM
Browse files

usb: core: log higher level message on malformed LANGID descriptor 



Commit 0cce2eda
     USB: fix LANGID=0 regression

defaults to a langid of 0x0409 if it's not properly implemented by the
device. Explain with a higher level error message what this means.

Signed-off-by: default avatarScot Doyle <lkml14@scotdoyle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Change-Id: I5b744d96a6aaaf95e5af645b9884d6941dfd1c79
parent 1684d3a9

drivers/usb/core/message.c

+1 −3
Original line number Diff line number Diff line
@@ -771,9 +771,7 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf) 
		dev->string_langid = 0x0409;

		dev->have_langid = 1;

		dev_err(&dev->dev,

			"string descriptor 0 malformed (err = %d), "

			"defaulting to 0x%04x\n",

				err, dev->string_langid);

			"language id specifier not provided by device, defaulting to English\n");

		return 0;

	}