Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d0a95b7 authored by Yingjoe Chen's avatar Yingjoe Chen Committed by TARKZiM
Browse files

i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr 



[ Upstream commit a0692f0eef91354b62c2b4c94954536536be5425 ]

If I2C_M_RECV_LEN check failed, msgs[i].buf allocated by memdup_user
will not be freed. Pump index up so it will be freed.

Fixes: 838bfa60 ("i2c-dev: Add support for I2C_M_RECV_LEN")
Signed-off-by: default avatarYingjoe Chen <yingjoe.chen@mediatek.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Change-Id: Ia4a4888ae6eb4b6b2a610700ab1facb29839ac86
parent 97acc936

drivers/i2c/i2c-dev.c

+1 −0
Original line number Diff line number Diff line
@@ -295,6 +295,7 @@ static noinline int i2cdev_ioctl_rdrw(struct i2c_client *client, 
			    rdwr_pa[i].buf[0] < 1 ||

			    rdwr_pa[i].len < rdwr_pa[i].buf[0] +

					     I2C_SMBUS_BLOCK_MAX) {

				i++;

				res = -EINVAL;

				break;

			}