Commit 3b1a9145 authored Nov 06, 2012 by Krzysztof Mazur Committed by David Woodhouse Nov 28, 2012

pppoatm: allow assign only on a connected socket



The pppoatm does not check if used vcc is in connected state,
causing an Oops in pppoatm_send() when vcc->send() is called
on not fully connected socket.

Now pppoatm can be assigned only on connected sockets; otherwise
-EINVAL error is returned.

Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent ec809bd8

net/atm/pppoatm.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -406,6 +406,8 @@ static int pppoatm_ioctl(struct socket *sock, unsigned int cmd,
		return -ENOIOCTLCMD;
		if (!capable(CAP_NET_ADMIN))
		return -EPERM;
		if (sock->state != SS_CONNECTED)
		return -EINVAL;
		return pppoatm_assign_vcc(atmvcc, argp);
		}
		case PPPIOCGCHAN: