Commit 3a5838da authored Oct 29, 2013 by Manu Gautam

msm: ehci-hsic: Don't change DEVICE name from driver



Some userspace scripts and other kernel modules may perform
binding/unbinding of HSIC driver at runtime.
Since, device name (also used for device-driver binding) may
change across targets if HSIC core is mapped at different address
and they use device tree for the configuration.
To overcome this driver currently overrides pdev->device name from
its probe routine but doesn't change pdev->name. This results in
pdev->name becoming a dangling pointer as the memory is freed by
dev_set_name call. Get rid of this code changing dev.name and
let the targets's board file override this using AUX_DATA mechanism.

CRs-fixed: 568103
Change-Id: I755044e8c73064c2c13dbb6e8e1002f38c9379e0
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>

parent 251b4cb7

drivers/usb/host/ehci-msm-hsic.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1951,7 +1951,6 @@ static int ehci_hsic_msm_probe(struct platform_device *pdev)
		if (pdev->dev.of_node) {
		dev_dbg(&pdev->dev, "device tree enabled\n");
		pdev->dev.platform_data = msm_hsic_dt_to_pdata(pdev);
		dev_set_name(&pdev->dev, ehci_msm_hsic_driver.driver.name);
		} else {
		/* explicitly pass wakeup_irq flag for !DT */
		wakeup_irq_flags = IRQF_TRIGGER_HIGH;