Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

This project is archived. Its data is read-only.

Commit 37f08be1 authored Feb 21, 2012 by Marcos Paulo de Souza Committed by Rafael J. Wysocki Mar 04, 2012

PM / Freezer: Remove references to TIF_FREEZE in comments



This patch removes all the references in the code about the TIF_FREEZE
flag removed by commit a3201227

    freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE

There still are some references to TIF_FREEZE in
Documentation/power/freezing-of-tasks.txt, but it looks like that
documentation needs more thorough work to reflect how the new
freezer works, and hence merely removing the references to TIF_FREEZE
won't really help. So I have not touched that part in this patch.

Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent 8671bbc1

kernel/exit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -424,7 +424,7 @@ void daemonize(const char *name, ...)
		*/
		exit_mm(current);
		/*
		* We don't want to have TIF_FREEZE set if the system-wide hibernation
		* We don't want to get frozen, in case system-wide hibernation
		* or suspend transition begins right now.
		*/
		current->flags \|= (PF_NOFREEZE \| PF_KTHREAD);

kernel/freezer.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -99,9 +99,9 @@ static void fake_signal_wake_up(struct task_struct *p)
		* freeze_task - send a freeze request to given task
		* @p: task to send the request to
		*
		* If @p is freezing, the freeze request is sent by setting %TIF_FREEZE
		* flag and either sending a fake signal to it or waking it up, depending
		* on whether it has %PF_FREEZER_NOSIG set.
		* If @p is freezing, the freeze request is sent either by sending a fake
		* signal (if it's not a kernel thread) or waking it up (if it's a kernel
		* thread).
		*
		* RETURNS:
		* %false, if @p is not freezing or already frozen; %true, otherwise

kernel/power/process.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -53,11 +53,9 @@ static int try_to_freeze_tasks(bool user_only)
		* It is "frozen enough". If the task does wake
		* up, it will immediately call try_to_freeze.
		*
		* Because freeze_task() goes through p's
		* scheduler lock after setting TIF_FREEZE, it's
		* guaranteed that either we see TASK_RUNNING or
		* try_to_stop() after schedule() in ptrace/signal
		* stop sees TIF_FREEZE.
		* Because freeze_task() goes through p's scheduler lock, it's
		* guaranteed that TASK_STOPPED/TRACED -> TASK_RUNNING
		* transition can't race with task state testing here.
		*/
		if (!task_is_stopped_or_traced(p) &&
		!freezer_should_skip(p))