Commit 37e64e5a authored Jul 05, 2006 by Mikael Pettersson Committed by David S. Miller Jul 05, 2006

[SPARC64]: Fix stack overflow checking in modular non-SMP kernels.



The sparc64 kernel's EXPORT_SYMBOL(_mcount) is inside an
#ifdef CONFIG_SMP. This breaks modules in non-SMP kernels
built with stack overflow checking (CONFIG_STACK_DEBUG=y),
as modules_install reports:

WARNING: /lib/modules/2.6.17/kernel/drivers/ide/ide-cd.ko needs unknown symbol _mcount

Trivially fixed by moving EXPORT_SYMBOL(_mcount) outside of
the #ifdef CONFIG_SMP.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7233589d

arch/sparc64/kernel/sparc64_ksyms.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -124,11 +124,6 @@ EXPORT_SYMBOL(__write_lock);
		EXPORT_SYMBOL(__write_unlock);
		EXPORT_SYMBOL(__write_trylock);

		#if defined(CONFIG_MCOUNT)
		extern void _mcount(void);
		EXPORT_SYMBOL(_mcount);
		#endif

		/* CPU online map and active count. */
		EXPORT_SYMBOL(cpu_online_map);
		EXPORT_SYMBOL(phys_cpu_present_map);
		@@ -136,6 +131,11 @@ EXPORT_SYMBOL(phys_cpu_present_map);
		EXPORT_SYMBOL(smp_call_function);
		#endif /* CONFIG_SMP */

		#if defined(CONFIG_MCOUNT)
		extern void _mcount(void);
		EXPORT_SYMBOL(_mcount);
		#endif

		EXPORT_SYMBOL(sparc64_get_clock_tick);

		/* semaphores */