Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 363b1c66 authored by Girish Mahadevan's avatar Girish Mahadevan
Browse files

msm: msm_bus: Prevent BKE swtich from overwriting other fields 



Incorrect bit mask could lead to other register fields getting
overwritten when doing a BKE bit switch.

Change-Id: I2cd7717eca48166dcc8cdb7ad855cc87e04c233b
Signed-off-by: default avatarGirish Mahadevan <girishm@codeaurora.org>
parent ff86e4ff

drivers/platform/msm/msm_bus/msm_bus_bimc.c

+4 −4
Original line number Diff line number Diff line
@@ -1470,12 +1470,12 @@ static void free_commit_data(void *cdata) 
static void bke_switch(

	void __iomem *baddr, uint32_t mas_index, bool req, int mode)

{

	uint32_t reg_val, val;

	uint32_t reg_val, val, cur_val;



	val = req << M_BKE_EN_EN_SHFT;

	reg_val = readl_relaxed(M_BKE_EN_ADDR(baddr, mas_index)) &

		M_BKE_EN_RMSK;

	if (val == reg_val)

	reg_val = readl_relaxed(M_BKE_EN_ADDR(baddr, mas_index));

	cur_val = reg_val & M_BKE_EN_RMSK;

	if (val == cur_val)

		return;



	if (!req && mode == BIMC_QOS_MODE_FIXED)