Commit 35d05778 authored Apr 05, 2008 by Trond Myklebust

NFSv4: Remove bogus call to nfs4_drop_state_owner() in _nfs4_open_expired()

There should be no need to invalidate a perfectly good state owner just
because of a stale filehandle. Doing so can cause the state recovery code
to break, since nfs4_get_renew_cred() and nfs4_get_setclientid_cred() rely
on finding active state owners.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent dbae4c73

fs/nfs/nfs4proc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -982,11 +982,8 @@ static int _nfs4_open_expired(struct nfs_open_context ctx, struct nfs4_state s
		if (IS_ERR(opendata))
		return PTR_ERR(opendata);
		ret = nfs4_open_recover(opendata, state);
		if (ret == -ESTALE) {
		/* Invalidate the state owner so we don't ever use it again */
		nfs4_drop_state_owner(state->owner);
		if (ret == -ESTALE)
		d_drop(ctx->path.dentry);
		}
		nfs4_opendata_put(opendata);
		return ret;
		}