Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f23f121 authored by Vivek Goyal's avatar Vivek Goyal Committed by Tejun Heo
Browse files

cfq-iosched: Get rid of unnecessary local variable 



Use of local varibale "n" seems to be unnecessary. Remove it. This brings
it inline with function __cfq_group_st_add(), which is also doing the
similar operation of adding a group to a rb tree.

No functionality change here.

Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Acked-by: default avatarJeff Moyer <jmoyer@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 6d816ec7

block/cfq-iosched.c

+2 −6
Original line number Diff line number Diff line
@@ -1658,8 +1658,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, 
	cfqq->service_tree = st;

	p = &st->rb.rb_node;

	while (*p) {

		struct rb_node **n;



		parent = *p;

		__cfqq = rb_entry(parent, struct cfq_queue, rb_node);
@@ -1667,13 +1665,11 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, 
		 * sort by key, that represents service time.

		 */

		if (time_before(rb_key, __cfqq->rb_key))

			n = &(*p)->rb_left;

			p = &parent->rb_left;

		else {

			n = &(*p)->rb_right;

			p = &parent->rb_right;

			left = 0;

		}



		p = n;

	}



	if (left)