Commit 1a823ac9 authored Feb 23, 2008 by Miklos Szeredi Committed by Linus Torvalds Feb 23, 2008

fuse: fix permission checking



I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.

How did this happen?

 - old err declaration in inner scope
 - new err getting declared in outer scope
 - 'return err' from inner scope getting removed
 - old declaration not being noticed

-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(

More testing would have also saved us :((

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fddd9cf8

fs/fuse/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -906,7 +906,7 @@ static int fuse_permission(struct inode inode, int mask, struct nameidata nd)
		}

		if (fc->flags & FUSE_DEFAULT_PERMISSIONS) {
		int err = generic_permission(inode, mask, NULL);
		err = generic_permission(inode, mask, NULL);

		/* If permission is denied, try to refresh file
		attributes. This is also needed, because the root