Commit 16cf1d0c authored Aug 21, 2007 by Trent Piepho Committed by Mauro Carvalho Chehab Oct 09, 2007

V4L/DVB (6082): cx88: Improve risc instruction printing in sram channel dump



When the risc instrunctions from the CMDS were printed, instruction arguments
weren't taken into account.

This changes output like:
cx88[0]:   risc0: 0x1d010400 [ write sol eol irq1 cnt0 count=1024 ]
cx88[0]:   risc1: 0x0cac2800 [ INVALID sol eol 23 21 19 18 13 count=2048 ]
cx88[0]:   risc2: 0x1d010400 [ write sol eol irq1 cnt0 count=1024 ]
cx88[0]:   risc3: 0x0cac2c00 [ INVALID sol eol 23 21 19 18 13 count=3072 ]

cx88[0]:   risc0: 0x1d010400 [ write sol eol irq1 cnt0 count=1024 ]
cx88[0]:   risc1: 0x0cac2800 [ arg #1 ]
cx88[0]:   risc2: 0x1d010400 [ write sol eol irq1 cnt0 count=1024 ]
cx88[0]:   risc3: 0x0cac2c00 [ arg #1 ]

Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

parent aeb292d1

drivers/media/video/cx88/cx88-core.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -434,10 +434,13 @@ void cx88_sram_channel_dump(struct cx88_core *core,
		printk("%s: cmds: %-12s: 0x%08x\n",
		core->name,name[i],
		cx_read(ch->cmds_start + 4*i));
		for (i = 0; i < 4; i++) {
		for (n = 1, i = 0; i < 4; i++) {
		risc = cx_read(ch->cmds_start + 4 * (i+11));
		printk("%s: risc%d: ", core->name, i);
		cx88_risc_decode(risc);
		if (--n)
		printk("0x%08x [ arg #%d ]\n", risc, n);
		else
		n = cx88_risc_decode(risc);
		}
		for (i = 0; i < 16; i += n) {
		risc = cx_read(ch->ctrl_start + 4 * i);