Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15c73d5a authored by James Bottomley's avatar James Bottomley
Browse files

[SCSI] libsas: Warn if ATA device detected but CONFIG_SCSI_SAS_ATA not set 



We give a very cryptic error if an ATA device is seen on a SAS port
but libsas isn't compiled to include libata to handle them.  Add an
extra warning to explain specifically what the problem is.

Acked-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 77cca462

drivers/scsi/libsas/sas_discover.c

+4 −1
Original line number Diff line number Diff line
@@ -295,11 +295,14 @@ static void sas_discover_domain(struct work_struct *work) 
	case FANOUT_DEV:

		error = sas_discover_root_expander(dev);

		break;

#ifdef CONFIG_SCSI_SAS_ATA

	case SATA_DEV:

	case SATA_PM:

#ifdef CONFIG_SCSI_SAS_ATA

		error = sas_discover_sata(dev);

		break;

#else

		SAS_DPRINTK("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");

		/* Fall through */

#endif

	default:

		error = -ENXIO;