Commit 152a649b authored Jan 27, 2009 by Casey Schaufler Committed by Linus Torvalds Jan 27, 2009

smackfs load append mode fix



Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Reviewed-by: James Morris <jmorris@namei.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e4a7ca29

security/smack/smackfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct file file, const char __user buf,
		break;
		case 'a':
		case 'A':
		rule.smk_access \|= MAY_READ;
		rule.smk_access \|= MAY_APPEND;
		break;
		default:
		goto out;