Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13762b11 authored by Benet Clark's avatar Benet Clark Committed by Gerrit - the friendly Code Review server
Browse files

msm: mdss: Handle error conditions in histogram interrupt handler 



In the chance that we get an interrupt for a histogram block that
is not enabled, we print an error message to alert of incorrect
functionality.

Change-Id: If99343fb2d385442d85b7d65c5c41fb48ccb2e25
Signed-off-by: default avatarBenet Clark <benetc@codeaurora.org>
parent 7d26df54

drivers/video/msm/mdss/mdss_mdp_pp.c

+15 −3
Original line number Diff line number Diff line
@@ -3894,12 +3894,24 @@ void mdss_mdp_hist_intr_done(u32 isr) 
			spin_unlock(&hist_info->hist_lock);

			if (need_complete)

				complete(&hist_info->comp);

		} else if (hist_info && (isr_blk & 0x1) &&

				!(hist_info->col_en)) {

			/*

			 * Histogram collection is disabled yet we got an

			 * interrupt somehow.

			 */

			pr_err("Hist[%d] Done interrupt, col_en=false!\n",

				blk_idx);

		}

		/* Histogram Reset Done Interrupt */

		if (hist_info && (isr_blk & 0x2) && (hist_info->col_en)) {

			spin_lock(&hist_info->hist_lock);

			hist_info->col_state = HIST_IDLE;

			spin_unlock(&hist_info->hist_lock);

		} else if (hist_info && (isr_blk & 0x2) &&

				!(hist_info->col_en)) {

			pr_err("Hist[%d] Reset Done interrupt, col_en=false!\n",

				blk_idx);

		}

	};

}