Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 112bf876 authored by Ravi Gummadidala's avatar Ravi Gummadidala
Browse files

msm: ipa: fix delete dependency bug in IPA RM 



Resource state was being passed instead of resource event
when notifying producer on delete_dependency. This will
cause client to ignore the "notification" and remain stuck
leading to completion timeout and BUG.

Change-Id: Idfc0e878c82de8dc86565fbbf03827acb3fb0478
Signed-off-by: default avatarRavi Gummadidala <rgummadi@codeaurora.org>
parent 7cb5bf37

drivers/platform/msm/ipa/ipa_rm_resource.c

+4 −1
Original line number Diff line number Diff line
@@ -609,6 +609,7 @@ int ipa_rm_resource_delete_dependency(struct ipa_rm_resource *resource, 
	unsigned long consumer_flags;

	bool state_changed = false;

	bool release_consumer = false;

	enum ipa_rm_event evt;

	if (!resource || !depends_on) {

		IPA_RM_ERR("invalid params\n");

		return -EINVAL;
@@ -640,6 +641,7 @@ int ipa_rm_resource_delete_dependency(struct ipa_rm_resource *resource, 
			resource)->pending_release == 0) {

			resource->state = IPA_RM_RELEASED;

			state_changed = true;

			evt = IPA_RM_RESOURCE_RELEASED;

		}

		spin_unlock_irqrestore(&depends_on->state_lock, consumer_flags);

		break;
@@ -655,6 +657,7 @@ int ipa_rm_resource_delete_dependency(struct ipa_rm_resource *resource, 
				resource)->pending_request == 0) {

			resource->state = IPA_RM_GRANTED;

			state_changed = true;

			evt = IPA_RM_RESOURCE_GRANTED;

		}

		spin_unlock_irqrestore(&depends_on->state_lock, consumer_flags);

		break;
@@ -667,7 +670,7 @@ int ipa_rm_resource_delete_dependency(struct ipa_rm_resource *resource, 
		ipa_rm_peers_list_has_last_peer(resource->peers_list)) {

		(void) ipa_rm_wq_send_cmd(IPA_RM_WQ_NOTIFY_PROD,

				resource->name,

				resource->state,

				evt,

				false);

		result = -EINPROGRESS;

	}