Commit 0f6efff9 authored Jun 14, 2012 by Dan Carpenter Committed by David S. Miller Jun 15, 2012

qlcnic: off by one in qlcnic_init_pci_info()



The adapter->npars[] array has QLCNIC_MAX_PCI_FUNC elements.  We
allocate it that way a few lines earlier in the function.  So this test
is off by one.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 62b1a8ab

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -479,7 +479,7 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)

	for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {		for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {
	pfn = pci_info[i].id;		pfn = pci_info[i].id;
	if (pfn > QLCNIC_MAX_PCI_FUNC) {		if (pfn >= QLCNIC_MAX_PCI_FUNC) {
	ret = QL_STATUS_INVALID_PARAM;		ret = QL_STATUS_INVALID_PARAM;
	goto err_eswitch;		goto err_eswitch;
	}		}