Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07d57a32 authored by Grant Likely's avatar Grant Likely
Browse files

drivercore: Output common devicetree information in uevent 



When userspace needs to find a specific device, it currently isn't easy to
resolve a /sys/devices/ path from a specific device tree node.  Nor is it
easy to obtain the compatible list for devices.

This patch generalizes the code that inserts OF_* values into the uevent
device attribute so that any device that is attached to an OF node will
have that information exported to userspace.  Without this patch only
platform devices and some powerpc-specific busses have access to this
data.

The original function also creates a MODALIAS property for the compatible
list, but that code has not been generalized into the common case because
it has the potential to break module loading on a lot of bus types.  Bus
types are still responsible for their own MODALIAS properties.

Boot tested on ARM and compile tested on PowerPC and SPARC.

Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tobias Klauser <tklauser@distanz.ch>
Cc: Frederic Lambert <frdrc66@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Mark Brown <broonie@sirena.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
parent 7aff0fe3

arch/powerpc/kernel/ibmebus.c

+1 −1
Original line number Diff line number Diff line
@@ -713,7 +713,7 @@ static struct dev_pm_ops ibmebus_bus_dev_pm_ops = { 


struct bus_type ibmebus_bus_type = {

	.name      = "ibmebus",

	.uevent    = of_device_uevent,

	.uevent    = of_device_uevent_modalias,

	.bus_attrs = ibmebus_bus_attrs,

	.match     = ibmebus_bus_bus_match,

	.probe     = ibmebus_bus_device_probe,

drivers/base/core.c

+5 −0
Original line number Diff line number Diff line
@@ -18,6 +18,8 @@ 
#include <linux/string.h>

#include <linux/kdev_t.h>

#include <linux/notifier.h>

#include <linux/of.h>

#include <linux/of_device.h>

#include <linux/genhd.h>

#include <linux/kallsyms.h>

#include <linux/mutex.h>
@@ -267,6 +269,9 @@ static int dev_uevent(struct kset *kset, struct kobject *kobj, 
	if (dev->driver)

		add_uevent_var(env, "DRIVER=%s", dev->driver->name);



	/* Add common DT information about the device */

	of_device_uevent(dev, env);



	/* have the bus specific function add its stuff */

	if (dev->bus && dev->bus->uevent) {

		retval = dev->bus->uevent(dev, env);

drivers/base/platform.c

+1 −1
Original line number Diff line number Diff line
@@ -621,7 +621,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env) 
	int rc;



	/* Some devices have extra OF data and an OF-style MODALIAS */

	rc = of_device_uevent(dev,env);

	rc = of_device_uevent_modalias(dev,env);

	if (rc != -ENODEV)

		return rc;

drivers/macintosh/macio_asic.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ extern struct device_attribute macio_dev_attrs[]; 
struct bus_type macio_bus_type = {

       .name	= "macio",

       .match	= macio_bus_match,

       .uevent = of_device_uevent,

       .uevent = of_device_uevent_modalias,

       .probe	= macio_device_probe,

       .remove	= macio_device_remove,

       .shutdown = macio_device_shutdown,

drivers/of/device.c

+16 −14
Original line number Diff line number Diff line
@@ -128,39 +128,41 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) 
/**

 * of_device_uevent - Display OF related uevent information

 */

int of_device_uevent(struct device *dev, struct kobj_uevent_env *env)

void of_device_uevent(struct device *dev, struct kobj_uevent_env *env)

{

	const char *compat;

	int seen = 0, cplen, sl;



	if ((!dev) || (!dev->of_node))

		return -ENODEV;



	if (add_uevent_var(env, "OF_NAME=%s", dev->of_node->name))

		return -ENOMEM;

		return;



	if (add_uevent_var(env, "OF_TYPE=%s", dev->of_node->type))

		return -ENOMEM;

	add_uevent_var(env, "OF_NAME=%s", dev->of_node->name);

	add_uevent_var(env, "OF_FULLNAME=%s", dev->of_node->full_name);

	if (dev->of_node->type && strcmp("<NULL>", dev->of_node->type) != 0)

		add_uevent_var(env, "OF_TYPE=%s", dev->of_node->type);



	/* Since the compatible field can contain pretty much anything

	 * it's not really legal to split it out with commas. We split it

	 * up using a number of environment variables instead. */



	compat = of_get_property(dev->of_node, "compatible", &cplen);

	while (compat && *compat && cplen > 0) {

		if (add_uevent_var(env, "OF_COMPATIBLE_%d=%s", seen, compat))

			return -ENOMEM;



		add_uevent_var(env, "OF_COMPATIBLE_%d=%s", seen, compat);

		sl = strlen(compat) + 1;

		compat += sl;

		cplen -= sl;

		seen++;

	}

	add_uevent_var(env, "OF_COMPATIBLE_N=%d", seen);

}



	if (add_uevent_var(env, "OF_COMPATIBLE_N=%d", seen))

		return -ENOMEM;

int of_device_uevent_modalias(struct device *dev, struct kobj_uevent_env *env)

{

	int sl;



	if ((!dev) || (!dev->of_node))

		return -ENODEV;



	/* modalias is trickier, we add it in 2 steps */

	/* Devicetree modalias is tricky, we add it in 2 steps */

	if (add_uevent_var(env, "MODALIAS="))

		return -ENOMEM;