Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06374141 authored by Jayasena Sangaraboina's avatar Jayasena Sangaraboina
Browse files

msm: vidc: Fix memory leak issue 



kmemdup, which is used to copy memory also allocates
memory before copying, so no need to allocate with
kzalloc.

Change-Id: Id54a289d19284ca5e4d203e47e7db3028ad5f68d
Signed-off-by: default avatarJayasena Sangaraboina <jsanga@codeaurora.org>
parent 0c2d6dd7

drivers/media/platform/msm/vidc/msm_vidc_common.c

+0 −8
Original line number Diff line number Diff line
@@ -609,17 +609,9 @@ static void handle_session_prop_info(enum command_response cmd, void *data) 
		dprintk(VIDC_ERR, "%s: getprop kzalloc failed\n", __func__);

		goto failed;

	}

	getprop->data = kzalloc(response->size, GFP_KERNEL);

	if (!getprop->data) {

		dprintk(VIDC_ERR, "%s: getprop->data kzalloc failed\n",

					__func__);

		kfree(getprop);

		goto failed;

	}

	getprop->data = kmemdup(response->data, response->size, GFP_KERNEL);

	if (!getprop->data) {

		dprintk(VIDC_ERR, "%s: kmemdup failed\n", __func__);

		kfree(getprop->data);

		kfree(getprop);

		goto failed;

	}