Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fee8bc1c authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Greg Kroah-Hartman
Browse files

USB: ehci-fsl: Use usb_put_transceiver instead of put_device 



Currently usb_put_transceiver calls put_device so this is a no-op but it
is better to keep API usage consistent as ehci->transceiver is allocated
with usb_get_transceiver.

While at there remove one extra ehci->transceiver test as the code block
has already tested it.

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bebc56d5

drivers/usb/host/ehci-fsl.c

+2 −3
Original line number Diff line number Diff line
@@ -150,8 +150,7 @@ static int usb_hcd_fsl_probe(const struct hc_driver *driver, 
			retval = otg_set_host(ehci->transceiver->otg,

					      &ehci_to_hcd(ehci)->self);

			if (retval) {

				if (ehci->transceiver)

					put_device(ehci->transceiver->dev);

				usb_put_transceiver(ehci->transceiver);

				goto err4;

			}

		} else {
@@ -195,7 +194,7 @@ static void usb_hcd_fsl_remove(struct usb_hcd *hcd, 


	if (ehci->transceiver) {

		otg_set_host(ehci->transceiver->otg, NULL);

		put_device(ehci->transceiver->dev);

		usb_put_transceiver(ehci->transceiver);

	}



	usb_remove_hcd(hcd);