Commit f8d2b920 authored Apr 14, 2014 by Amitkumar Karwar Committed by John W. Linville Apr 15, 2014

mwifiex: fix hung task on command timeout



Sometimes when command timeout occurs due to a firmware or
hardware bug, there may be some synchronous commands in command
queue. These commands are never downloaded to firmware causing
hung task warnings. This patch replaces wait_event_interruptible
call with wait_event_interruptible_timeout to fix the issue.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 20474129

drivers/net/wireless/mwifiex/sta_ioctl.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -60,9 +60,10 @@ int mwifiex_wait_queue_complete(struct mwifiex_adapter *adapter,
		int status;

		/* Wait for completion */
		status = wait_event_interruptible(adapter->cmd_wait_q.wait,
		*(cmd_queued->condition));
		if (status) {
		status = wait_event_interruptible_timeout(adapter->cmd_wait_q.wait,
		*(cmd_queued->condition),
		(12 * HZ));
		if (status <= 0) {
		dev_err(adapter->dev, "cmd_wait_q terminated: %d\n", status);
		mwifiex_cancel_all_pending_cmd(adapter);
		return status;