Commit f4745a92 authored Jun 29, 2015 by Colin Ian King Committed by Rafael J. Wysocki Jul 17, 2015

PM / clk: don't return int on __pm_clk_enable()



Static analysis by cppcheck found an issue that was recently introduced by
commit 471f7707 ("PM / clock_ops: make __pm_clk_enable more generic")
where a return status in ret was not being initialised and garbage
being returned when ce->status >= PCE_STATUS_ERROR.

The fact that ret is not being checked by the caller and that
ret is only used internally __pm_clk_enable() to check if clk_enable()
was OK means we can ignore returning it instead turn
__pm_clk_enable() into function with a void return.

Fixes: 471f7707 ("PM / clock_ops: make __pm_clk_enable more generic")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 21bdb584

drivers/base/power/clock_ops.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -38,7 +38,7 @@ struct pm_clock_entry {
	* @dev: The device for the given clock		* @dev: The device for the given clock
	* @ce: PM clock entry corresponding to the clock.		* @ce: PM clock entry corresponding to the clock.
	*/		*/
	static inline int __pm_clk_enable(struct device dev, struct pm_clock_entry ce)		static inline void __pm_clk_enable(struct device dev, struct pm_clock_entry ce)
	{		{
	int ret;		int ret;

	@@ -50,8 +50,6 @@ static inline int __pm_clk_enable(struct device dev, struct pm_clock_entry ce)
	dev_err(dev, "%s: failed to enable clk %p, error %d\n",		dev_err(dev, "%s: failed to enable clk %p, error %d\n",
	__func__, ce->clk, ret);		__func__, ce->clk, ret);
	}		}

	return ret;
	}		}

	/**		/**