Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2f96d20 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] fcoe: precedence bug in fcoe_filter_frames() 



Negate has higher precedence than bitwise AND.  FCPHF_CRC_UNCHECKED is
0x1 so the original code is equivalent to: if (!fr_flags(fp)) { ...

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 70be6344

drivers/scsi/fcoe/fcoe.c

+1 −1
Original line number Diff line number Diff line
@@ -1548,7 +1548,7 @@ static inline int fcoe_filter_frames(struct fc_lport *lport, 
		return -EINVAL;

	}



	if (!fr_flags(fp) & FCPHF_CRC_UNCHECKED ||

	if (!(fr_flags(fp) & FCPHF_CRC_UNCHECKED) ||

	    le32_to_cpu(fr_crc(fp)) == ~crc32(~0, skb->data, skb->len)) {

		fr_flags(fp) &= ~FCPHF_CRC_UNCHECKED;

		return 0;