Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2c2e255 authored by Christian Lamparter's avatar Christian Lamparter Committed by John W. Linville
Browse files

p54: fix build warnings 



On Saturday 25 October 2008 10:24:10 Johannes Berg wrote:
> just FYI in case you haven't seen them. the p54 one looks like a genuine
> problem.
>
> drivers/net/wireless/p54/p54common.c: In function ‘p54_parse_eeprom’:
> drivers/net/wireless/p54/p54common.c:325: warning: ‘synth’ may be used uninitialized in this function

There you go. Yes, it is a genuine problem, if the device's eeprom is screwed really up.

Signed-off-by: default avatarChristian Lamparter <chunkeey@web.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent bc1b32d6

drivers/net/wireless/p54/p54common.c

+3 −2
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) 
	void *tmp;

	int err;

	u8 *end = (u8 *)eeprom + len;

	u16 synth;

	u16 synth = 0;

	DECLARE_MAC_BUF(mac);



	wrap = (struct eeprom_pda_wrap *) eeprom;
@@ -422,7 +422,8 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) 
		entry = (void *)entry + (entry_len + 1)*2;

	}



	if (!priv->iq_autocal || !priv->output_limit || !priv->curve_data) {

	if (!synth || !priv->iq_autocal || !priv->output_limit ||

	    !priv->curve_data) {

		printk(KERN_ERR "p54: not all required entries found in eeprom!\n");

		err = -EINVAL;

		goto err;