Commit effc6cc8 authored Feb 13, 2012 by Roland Dreier Committed by Nicholas Bellinger Feb 25, 2012

target: Don't set WBUS16 or SYNC bits in INQUIRY response



SPC-4 says about the WBUS16 and SYNC bits:

    The meanings of these fields are specific to SPI-5 (see 6.4.3).
    For SCSI transport protocols other than the SCSI Parallel
    Interface, these fields are reserved.

We don't have a SPI fabric module, so we should never set these bits.
(The comment was misleading, since it only mentioned Sync but the
actual code set WBUS16 too).

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 089461dd

drivers/target/target_core_cdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -95,7 +95,7 @@ target_emulate_inquiry_std(struct se_cmd cmd, char buf)
		if (dev->se_sub_dev->t10_alua.alua_type == SPC3_ALUA_EMULATED)
		target_fill_alua_data(lun->lun_sep, buf);

		buf[7] = 0x32; /* Sync=1 and CmdQue=1 */
		buf[7] = 0x2; /* CmdQue=1 */

		snprintf(&buf[8], 8, "LIO-ORG");
		snprintf(&buf[16], 16, "%s", dev->se_sub_dev->t10_wwn.model);