Commit ef8034d0 authored Sep 07, 2007 by Jeremy Kerr Committed by Paul Mackerras Sep 11, 2007

[POWERPC] cell/PS3: Always set master run control bit in mfc_sr1_set



At present, running any SPE program on the ps3 will trigger a BUG_ON
when spufs_run_spu tries to clear the master run control bit, as lv1
does not make the master run control available to Linux.

This change makes SPE apps work again by disabling changes to the
master run control on PS3.  Although we don't have the facility to
disable a SPE with supervisor-level privileges, it's better than
hitting the BUG_ON unconditionally.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Acked-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent b7f90a40

arch/powerpc/platforms/ps3/spu.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -505,6 +505,8 @@ static void mfc_sr1_set(struct spu *spu, u64 sr1)
		static const u64 allowed = ~(MFC_STATE1_LOCAL_STORAGE_DECODE_MASK
		\| MFC_STATE1_PROBLEM_STATE_MASK);

		sr1 \|= MFC_STATE1_MASTER_RUN_CONTROL_MASK;

		BUG_ON((sr1 & allowed) != (spu_pdata(spu)->cache.sr1 & allowed));

		spu_pdata(spu)->cache.sr1 = sr1;