Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1013f14 authored Jul 16, 2012 by Roland Dreier Committed by Nicholas Bellinger Jul 16, 2012

qla2xxx: Remove racy, now-redundant check of sess_tearing_down

Now that target_submit_cmd() / target_get_sess_cmd() check
sess_tearing_down before adding commands to the list, we no longer
need the check in qlt_do_work().  In fact this check is racy anyway
(and that race is what inspired the change to add the check of
sess_tearing_down to the target core).

Cc: Chad Dupuis <chad.dupuis@qlogic.com>
Cc: Arun Easi <arun.easi@qlogic.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent bc187ea6

drivers/scsi/qla2xxx/qla_target.c

+3 −13

Original line number	Original line	Diff line number	Diff line
	@@ -2643,19 +2643,9 @@ static void qlt_do_work(struct work_struct *work)
	spin_lock_irqsave(&ha->hardware_lock, flags);		spin_lock_irqsave(&ha->hardware_lock, flags);
	sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,		sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,
	atio->u.isp24.fcp_hdr.s_id);		atio->u.isp24.fcp_hdr.s_id);
	if (sess) {		/* Do kref_get() before dropping qla_hw_data->hardware_lock. */
	if (unlikely(sess->se_sess->sess_tearing_down)) {		if (sess)
	sess = NULL;
	spin_unlock_irqrestore(&ha->hardware_lock, flags);
	goto out_term;
	} else {
	/*
	* Do the extra kref_get() before dropping
	* qla_hw_data->hardware_lock.
	*/
	kref_get(&sess->se_sess->sess_kref);		kref_get(&sess->se_sess->sess_kref);
	}
	}
	spin_unlock_irqrestore(&ha->hardware_lock, flags);		spin_unlock_irqrestore(&ha->hardware_lock, flags);

	if (unlikely(!sess)) {		if (unlikely(!sess)) {