Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ded00142 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

sh: off by one BUG_ON() in setup_bootmem_node() 



This off by one bug is harmless but it upsets the static checkers and the
code is obvious so it doesn't hurt to fix it.  The Smatch warning is:

    arch/sh/mm/numa.c:47 setup_bootmem_node()
    error: buffer overflow 'node_data' 1024 <= 1024

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7b990789

arch/sh/mm/numa.c

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ void __init setup_bootmem_node(int nid, unsigned long start, unsigned long end) 
	unsigned long bootmem_paddr;



	/* Don't allow bogus node assignment */

	BUG_ON(nid > MAX_NUMNODES || nid <= 0);

	BUG_ON(nid >= MAX_NUMNODES || nid <= 0);



	start_pfn = start >> PAGE_SHIFT;

	end_pfn = end >> PAGE_SHIFT;