Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc8738d9 authored by Moiz Sonasath's avatar Moiz Sonasath Committed by Felipe Balbi
Browse files

usb: otg: twl6030-usb: Fix twl writes 



There were mistakes in writing to few twl
registers. There was interchange in the
parameters being passed to twl6030_writeb().

Signed-off-by: default avatarMoiz Sonasath <m-sonasath@ti.com>
Signed-off-by: default avatarRuslan Bilovol <ruslan.bilovol@ti.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent e8d4e8be

drivers/usb/otg/twl6030-usb.c

+6 −9
Original line number Diff line number Diff line
@@ -305,9 +305,8 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl) 


		regulator_enable(twl->usb3v3);

		twl->asleep = 1;

		twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_EN_HI_CLR, 0x1);

		twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_EN_HI_SET,

								0x10);

		twl6030_writeb(twl, TWL_MODULE_USB, 0x1, USB_ID_INT_EN_HI_CLR);

		twl6030_writeb(twl, TWL_MODULE_USB, 0x10, USB_ID_INT_EN_HI_SET);

		status = USB_EVENT_ID;

		otg->default_a = true;

		twl->phy.state = OTG_STATE_A_IDLE;
@@ -316,12 +315,10 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl) 
		atomic_notifier_call_chain(&twl->phy.notifier, status,

							otg->gadget);

	} else  {

		twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_EN_HI_CLR,

								0x10);

		twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_EN_HI_SET,

								0x1);

		twl6030_writeb(twl, TWL_MODULE_USB, 0x10, USB_ID_INT_EN_HI_CLR);

		twl6030_writeb(twl, TWL_MODULE_USB, 0x1, USB_ID_INT_EN_HI_SET);

	}

	twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_LATCH_CLR, status);

	twl6030_writeb(twl, TWL_MODULE_USB, status, USB_ID_INT_LATCH_CLR);



	return IRQ_HANDLED;

}
@@ -343,7 +340,7 @@ static int twl6030_enable_irq(struct usb_phy *x) 
{

	struct twl6030_usb *twl = phy_to_twl(x);



	twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_EN_HI_SET, 0x1);

	twl6030_writeb(twl, TWL_MODULE_USB, 0x1, USB_ID_INT_EN_HI_SET);

	twl6030_interrupt_unmask(0x05, REG_INT_MSK_LINE_C);

	twl6030_interrupt_unmask(0x05, REG_INT_MSK_STS_C);