Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d63885da authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Daniel Vetter
Browse files

drm/i915: reset intel_encoder->type when DP or HDMI is detected 



When intel_hdmi_detect detects a monitor, set intel_encoder->type with
INTEL_OUTPUT_HDMI. Same for DP.

This should not break the current code because these variables never
change. This will be used after we create the DDI encoder because it
will have both DP and HDMI connectors.

We won't support eDP+HDMI on the same port, so if an encoder is eDP we
should expect it to always remain eDP and never change.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent f0fec3f2

drivers/gpu/drm/i915/intel_dp.c

+4 −0
Original line number Diff line number Diff line
@@ -2293,6 +2293,8 @@ static enum drm_connector_status 
intel_dp_detect(struct drm_connector *connector, bool force)

{

	struct intel_dp *intel_dp = intel_attached_dp(connector);

	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);

	struct intel_encoder *intel_encoder = &intel_dig_port->base;

	struct drm_device *dev = connector->dev;

	enum drm_connector_status status;

	struct edid *edid = NULL;
@@ -2324,6 +2326,8 @@ intel_dp_detect(struct drm_connector *connector, bool force) 
		}

	}



	if (intel_encoder->type != INTEL_OUTPUT_EDP)

		intel_encoder->type = INTEL_OUTPUT_DISPLAYPORT;

	return connector_status_connected;

}

drivers/gpu/drm/i915/intel_hdmi.c

+4 −0
Original line number Diff line number Diff line
@@ -792,6 +792,9 @@ static enum drm_connector_status 
intel_hdmi_detect(struct drm_connector *connector, bool force)

{

	struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);

	struct intel_digital_port *intel_dig_port =

		hdmi_to_dig_port(intel_hdmi);

	struct intel_encoder *intel_encoder = &intel_dig_port->base;

	struct drm_i915_private *dev_priv = connector->dev->dev_private;

	struct edid *edid;

	enum drm_connector_status status = connector_status_disconnected;
@@ -820,6 +823,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) 
		if (intel_hdmi->force_audio != HDMI_AUDIO_AUTO)

			intel_hdmi->has_audio =

				(intel_hdmi->force_audio == HDMI_AUDIO_ON);

		intel_encoder->type = INTEL_OUTPUT_HDMI;

	}



	return status;