Commit d4fc6dbb authored Mar 31, 2010 by Hagen Paul Pfeifer Committed by David S. Miller Apr 01, 2010

ipv4: remove redundant verification code



The check if error signaling is wanted (inet->recverr != 0) is done by
the caller: raw.c:raw_err() and udp.c:__udp4_lib_err(), so there is no
need to check this condition again.

Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 430e55b1

net/ipv4/ip_sockglue.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -286,12 +286,8 @@ int ip_ra_control(struct sock *sk, unsigned char on,
		void ip_icmp_error(struct sock sk, struct sk_buff skb, int err,
		__be16 port, u32 info, u8 *payload)
		{
		struct inet_sock *inet = inet_sk(sk);
		struct sock_exterr_skb *serr;

		if (!inet->recverr)
		return;

		skb = skb_clone(skb, GFP_ATOMIC);
		if (!skb)
		return;