Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d35abdb2 authored by Al Viro's avatar Al Viro
Browse files

hold task_lock around checks in keyctl 



Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 6120d3db

security/keys/keyctl.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -1486,6 +1486,7 @@ long keyctl_session_to_parent(void) 
	oldwork = NULL;

	oldwork = NULL;

	parent = me->real_parent;

	parent = me->real_parent;





	task_lock(parent);

	/* the parent mustn't be init and mustn't be a kernel thread */

	/* the parent mustn't be init and mustn't be a kernel thread */

	if (parent->pid <= 1 || !parent->mm)

	if (parent->pid <= 1 || !parent->mm)

		goto unlock;

		goto unlock;
@@ -1529,6 +1530,7 @@ long keyctl_session_to_parent(void) 
	if (!ret)

	if (!ret)

		newwork = NULL;

		newwork = NULL;

unlock:

unlock:

	task_unlock(parent);

	write_unlock_irq(&tasklist_lock);

	write_unlock_irq(&tasklist_lock);

	rcu_read_unlock();

	rcu_read_unlock();

	if (oldwork)

	if (oldwork)