Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce09affc authored by Kim, Milo's avatar Kim, Milo Committed by Anton Vorontsov
Browse files

lp8727_charger: Coding style changes 



1. Useless braces were omitted
2. Useless void casts were omitted
3. module exit name changed
   lp8727_chg_exit -> lp8727_exit
4. Pointer coding style changes
   no space between pointer('*') and pointer name
   ex) u8 * data -> u8 *data
5. Author information change : email and additional author

Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: default avatarAnton Vorontsov <cbouatmailru@gmail.com>
parent 998a8e7a

drivers/power/lp8727_charger.c

+25 −25
Original line number Original line Diff line number Diff line
@@ -153,21 +153,21 @@ static void lp8727_init_device(struct lp8727_chg *pchg) 
static int lp8727_is_dedicated_charger(struct lp8727_chg *pchg)

static int lp8727_is_dedicated_charger(struct lp8727_chg *pchg)

{

{

	u8 val;

	u8 val;

	(void)lp8727_i2c_read_byte(pchg, STATUS1, &val);

	lp8727_i2c_read_byte(pchg, STATUS1, &val);

	return (val & DCPORT);

	return (val & DCPORT);

}

}





static int lp8727_is_usb_charger(struct lp8727_chg *pchg)

static int lp8727_is_usb_charger(struct lp8727_chg *pchg)

{

{

	u8 val;

	u8 val;

	(void)lp8727_i2c_read_byte(pchg, STATUS1, &val);

	lp8727_i2c_read_byte(pchg, STATUS1, &val);

	return (val & CHPORT);

	return (val & CHPORT);

}

}





static void lp8727_ctrl_switch(struct lp8727_chg *pchg, u8 sw)

static void lp8727_ctrl_switch(struct lp8727_chg *pchg, u8 sw)

{

{

	u8 val = sw;

	u8 val = sw;

	(void)lp8727_i2c_write_byte(pchg, SWCTRL, &val);

	lp8727_i2c_write_byte(pchg, SWCTRL, &val);

}

}





static void lp8727_id_detection(struct lp8727_chg *pchg, u8 id, int vbusin)

static void lp8727_id_detection(struct lp8727_chg *pchg, u8 id, int vbusin)
@@ -207,9 +207,9 @@ static void lp8727_enable_chgdet(struct lp8727_chg *pchg) 
{

{

	u8 val;

	u8 val;





	(void)lp8727_i2c_read_byte(pchg, CTRL2, &val);

	lp8727_i2c_read_byte(pchg, CTRL2, &val);

	val |= CHGDET_EN;

	val |= CHGDET_EN;

	(void)lp8727_i2c_write_byte(pchg, CTRL2, &val);

	lp8727_i2c_write_byte(pchg, CTRL2, &val);

}

}





static void lp8727_delayed_func(struct work_struct *_work)

static void lp8727_delayed_func(struct work_struct *_work)
@@ -283,10 +283,9 @@ static int lp8727_charger_get_property(struct power_supply *psy, 
{

{

	struct lp8727_chg *pchg = dev_get_drvdata(psy->dev->parent);

	struct lp8727_chg *pchg = dev_get_drvdata(psy->dev->parent);





	if (psp == POWER_SUPPLY_PROP_ONLINE) {

	if (psp == POWER_SUPPLY_PROP_ONLINE)

		val->intval = lp8727_is_charger_attached(psy->name,

		val->intval = lp8727_is_charger_attached(psy->name,

							 pchg->devid);

							 pchg->devid);

	}





	return 0;

	return 0;

}

}
@@ -301,7 +300,7 @@ static int lp8727_battery_get_property(struct power_supply *psy, 
	switch (psp) {

	switch (psp) {

	case POWER_SUPPLY_PROP_STATUS:

	case POWER_SUPPLY_PROP_STATUS:

		if (lp8727_is_charger_attached(psy->name, pchg->devid)) {

		if (lp8727_is_charger_attached(psy->name, pchg->devid)) {

			(void)lp8727_i2c_read_byte(pchg, STATUS1, &read);

			lp8727_i2c_read_byte(pchg, STATUS1, &read);

			if (((read & CHGSTAT) >> 4) == EOC)

			if (((read & CHGSTAT) >> 4) == EOC)

				val->intval = POWER_SUPPLY_STATUS_FULL;

				val->intval = POWER_SUPPLY_STATUS_FULL;

			else

			else
@@ -311,7 +310,7 @@ static int lp8727_battery_get_property(struct power_supply *psy, 
		}

		}

		break;

		break;

	case POWER_SUPPLY_PROP_HEALTH:

	case POWER_SUPPLY_PROP_HEALTH:

		(void)lp8727_i2c_read_byte(pchg, STATUS2, &read);

		lp8727_i2c_read_byte(pchg, STATUS2, &read);

		read = (read & TEMP_STAT) >> 5;

		read = (read & TEMP_STAT) >> 5;

		if (read >= 0x1 && read <= 0x3)

		if (read >= 0x1 && read <= 0x3)

			val->intval = POWER_SUPPLY_HEALTH_OVERHEAT;

			val->intval = POWER_SUPPLY_HEALTH_OVERHEAT;
@@ -352,7 +351,7 @@ static void lp8727_charger_changed(struct power_supply *psy) 
			eoc_level = pchg->chg_parm->eoc_level;

			eoc_level = pchg->chg_parm->eoc_level;

			ichg = pchg->chg_parm->ichg;

			ichg = pchg->chg_parm->ichg;

			val = (ichg << 4) | eoc_level;

			val = (ichg << 4) | eoc_level;

			(void)lp8727_i2c_write_byte(pchg, CHGCTRL2, &val);

			lp8727_i2c_write_byte(pchg, CHGCTRL2, &val);

		}

		}

	}

	}

}

}
@@ -412,13 +411,14 @@ static void lp8727_unregister_psy(struct lp8727_chg *pchg) 
{

{

	struct lp8727_psy *psy = pchg->psy;

	struct lp8727_psy *psy = pchg->psy;





	if (psy) {

	if (!psy)

		return;



	power_supply_unregister(&psy->ac);

	power_supply_unregister(&psy->ac);

	power_supply_unregister(&psy->usb);

	power_supply_unregister(&psy->usb);

	power_supply_unregister(&psy->batt);

	power_supply_unregister(&psy->batt);

	kfree(psy);

	kfree(psy);

}

}

}





static int lp8727_probe(struct i2c_client *cl, const struct i2c_device_id *id)

static int lp8727_probe(struct i2c_client *cl, const struct i2c_device_id *id)

{

{
@@ -443,10 +443,9 @@ static int lp8727_probe(struct i2c_client *cl, const struct i2c_device_id *id) 
	lp8727_intr_config(pchg);

	lp8727_intr_config(pchg);





	ret = lp8727_register_psy(pchg);

	ret = lp8727_register_psy(pchg);

	if (ret) {

	if (ret)

		dev_err(pchg->dev,

		dev_err(pchg->dev,

			"can not register power supplies. err=%d", ret);

			"can not register power supplies. err=%d", ret);

	}





	return 0;

	return 0;

}

}
@@ -481,14 +480,15 @@ static int __init lp8727_init(void) 
	return i2c_add_driver(&lp8727_driver);

	return i2c_add_driver(&lp8727_driver);

}

}





static void __exit lp8727_chg_exit(void)

static void __exit lp8727_exit(void)

{

{

	i2c_del_driver(&lp8727_driver);

	i2c_del_driver(&lp8727_driver);

}

}





module_init(lp8727_init);

module_init(lp8727_init);

module_exit(lp8727_chg_exit);

module_exit(lp8727_exit);





MODULE_DESCRIPTION("National Semiconductor LP8727 charger driver");

MODULE_DESCRIPTION("National Semiconductor LP8727 charger driver");

MODULE_AUTHOR("Woogyom Kim <milo.kim@nsc.com>");

MODULE_AUTHOR

    ("Woogyom Kim <milo.kim@ti.com>, Daniel Jeong <daniel.jeong@ti.com>");

MODULE_LICENSE("GPL");
 
MODULE_LICENSE("GPL");