Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cafcd80d authored by Don Zickus's avatar Don Zickus Committed by Frederic Weisbecker
Browse files

lockup_detector: Cross arch compile fixes 



Combining the softlockup and hardlockup code causes watchdog.c
to build even without the hardlockup detection support.

So if an arch, that has the previous and the new nmi watchdog
implementations cohabiting, wants to know if the generic one
is in use, CONFIG_LOCKUP_DETECTOR is not a reliable check.
We need to use CONFIG_HARDLOCKUP_DETECTOR instead.

Fixes:
	kernel/built-in.o: In function `touch_nmi_watchdog':
	(.text+0x449bc): multiple definition of `touch_nmi_watchdog'
	arch/sparc/kernel/built-in.o:(.text+0x11b28): first defined here

Signed-off-by: default avatarDon Zickus <dzickus@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <20100514151121.GR15159@redhat.com>
[ use CONFIG_HARDLOCKUP_DETECTOR instead of CONFIG_PERF_EVENTS_NMI]
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent 23637d47

arch/x86/kernel/apic/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -3,10 +3,10 @@ 
#



obj-$(CONFIG_X86_LOCAL_APIC)	+= apic.o apic_noop.o probe_$(BITS).o ipi.o

ifneq ($(CONFIG_LOCKUP_DETECTOR),y)

ifneq ($(CONFIG_HARDLOCKUP_DETECTOR),y)

obj-$(CONFIG_X86_LOCAL_APIC)	+= nmi.o

endif

obj-$(CONFIG_LOCKUP_DETECTOR)	+= hw_nmi.o

obj-$(CONFIG_HARDLOCKUP_DETECTOR)	+= hw_nmi.o



obj-$(CONFIG_X86_IO_APIC)	+= io_apic.o

obj-$(CONFIG_SMP)		+= ipi.o

include/linux/nmi.h

+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ extern void touch_nmi_watchdog(void); 
extern void acpi_nmi_disable(void);

extern void acpi_nmi_enable(void);

#else

#ifndef CONFIG_LOCKUP_DETECTOR

#ifndef CONFIG_HARDLOCKUP_DETECTOR

static inline void touch_nmi_watchdog(void)

{

	touch_softlockup_watchdog();

kernel/watchdog.c

+5 −2
Original line number Diff line number Diff line
@@ -31,13 +31,13 @@ int watchdog_enabled; 
int __read_mostly softlockup_thresh = 60;



static DEFINE_PER_CPU(unsigned long, watchdog_touch_ts);

static DEFINE_PER_CPU(bool, watchdog_nmi_touch);

static DEFINE_PER_CPU(struct task_struct *, softlockup_watchdog);

static DEFINE_PER_CPU(struct hrtimer, watchdog_hrtimer);

static DEFINE_PER_CPU(bool, softlockup_touch_sync);

static DEFINE_PER_CPU(bool, hard_watchdog_warn);

static DEFINE_PER_CPU(bool, soft_watchdog_warn);

#ifdef CONFIG_HARDLOCKUP_DETECTOR

static DEFINE_PER_CPU(bool, hard_watchdog_warn);

static DEFINE_PER_CPU(bool, watchdog_nmi_touch);

static DEFINE_PER_CPU(unsigned long, hrtimer_interrupts);

static DEFINE_PER_CPU(unsigned long, hrtimer_interrupts_saved);

static DEFINE_PER_CPU(struct perf_event *, watchdog_ev);
@@ -139,6 +139,7 @@ void touch_all_softlockup_watchdogs(void) 
		per_cpu(watchdog_touch_ts, cpu) = 0;

}



#ifdef CONFIG_HARDLOCKUP_DETECTOR

void touch_nmi_watchdog(void)

{

	__get_cpu_var(watchdog_nmi_touch) = true;
@@ -146,6 +147,8 @@ void touch_nmi_watchdog(void) 
}

EXPORT_SYMBOL(touch_nmi_watchdog);



#endif



void touch_softlockup_watchdog_sync(void)

{

	__raw_get_cpu_var(softlockup_touch_sync) = true;