Commit c1ce7f10 authored Nov 26, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Dec 03, 2013

staging: comedi: mpc624: remove unnecessary test



It's not necessaary to vaidate insn->n passed to the (*insn_read)
function. The for() loop following it will just be a NOP.

Remove the test as well as the printk noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b1ca6b1d

drivers/staging/comedi/drivers/mpc624.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -159,10 +159,6 @@ static int mpc624_ai_rinsn(struct comedi_device *dev,
		* We always write 0 to GNSWA bit, so the channel range is +-/10.1Vdc
		*/
		outb(insn->chanspec, dev->iobase + MPC624_GNMUXCH);
		if (!insn->n) {
		printk(KERN_INFO "MPC624: Warning, no data to acquire\n");
		return 0;
		}

		for (n = 0; n < insn->n; n++) {
		/* Trigger the conversion */