Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0cdfaa0 authored by Axel Lin's avatar Axel Lin Committed by Grant Likely
Browse files

of/irq: Avoid calling list_first_entry() for empty list 



list_first_entry() expects the list is not empty, we need to check if list is
empty before calling list_first_entry(). Thus use list_first_entry_or_null()
instead of list_first_entry().

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarGrant Likely <grant.likely@linaro.org>
parent cfd1ee3e

drivers/of/irq.c

+3 −2
Original line number Diff line number Diff line
@@ -482,8 +482,9 @@ void __init of_irq_init(const struct of_device_id *matches) 
		}



		/* Get the next pending parent that might have children */

		desc = list_first_entry(&intc_parent_list, typeof(*desc), list);

		if (list_empty(&intc_parent_list) || !desc) {

		desc = list_first_entry_or_null(&intc_parent_list,

						typeof(*desc), list);

		if (!desc) {

			pr_err("of_irq_init: children remain, but no parents\n");

			break;

		}