Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be6800a7 authored by NeilBrown's avatar NeilBrown
Browse files

md: don't insist on valid event count for spare devices. 



Devices which know that they are spares do not really need to have
an event count that matches the rest of the array, so there are no
data-in-sync issues. It is enough that the uuid matches.
So remove the requirement that the event count is up-to-date.

We currently still write out and event count on spares, but this
allows us in a year or 3 to stop doing that completely.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent a8707c08

drivers/md/md.c

+13 −6
Original line number Diff line number Diff line
@@ -1070,8 +1070,11 @@ static int super_90_validate(mddev_t *mddev, mdk_rdev_t *rdev) 
				mddev->bitmap_info.default_offset;



	} else if (mddev->pers == NULL) {

		/* Insist on good event counter while assembling */

		/* Insist on good event counter while assembling, except

		 * for spares (which don't need an event count) */

		++ev1;

		if (sb->disks[rdev->desc_nr].state & (

			    (1<<MD_DISK_SYNC) | (1 << MD_DISK_ACTIVE)))

			if (ev1 < mddev->events) 

				return -EINVAL;

	} else if (mddev->bitmap) {
@@ -1469,8 +1472,12 @@ static int super_1_validate(mddev_t *mddev, mdk_rdev_t *rdev) 
		}



	} else if (mddev->pers == NULL) {

		/* Insist of good event counter while assembling */

		/* Insist of good event counter while assembling, except for

		 * spares (which don't need an event count) */

		++ev1;

		if (rdev->desc_nr >= 0 &&

		    rdev->desc_nr < le32_to_cpu(sb->max_dev) &&

		    le16_to_cpu(sb->dev_roles[rdev->desc_nr]) < 0xfffe)

			if (ev1 < mddev->events)

				return -EINVAL;

	} else if (mddev->bitmap) {