Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9c48649 authored by Dave Chinner's avatar Dave Chinner
Browse files

xfs: xfs_buf_iomove() doesn't care about signedness 



xfs_buf_iomove() uses xfs_caddr_t as it's parameter types, but it doesn't
care about the signedness of the variables as it is just copying the
data. Change the prototype to use void * so that we don't get sign
warnings at call sites.

Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent a3380ae3

fs/xfs/linux-2.6/xfs_buf.c

+1 −1
Original line number Diff line number Diff line
@@ -1443,7 +1443,7 @@ xfs_buf_iomove( 
	xfs_buf_t		*bp,	/* buffer to process		*/

	size_t			boff,	/* starting buffer offset	*/

	size_t			bsize,	/* length to copy		*/

	caddr_t			data,	/* data address			*/

	void			*data,	/* data address			*/

	xfs_buf_rw_t		mode)	/* read/write/zero flag		*/

{

	size_t			bend, cpoff, csize;

fs/xfs/linux-2.6/xfs_buf.h

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ extern void xfs_buf_ioend(xfs_buf_t *, int); 
extern void xfs_buf_ioerror(xfs_buf_t *, int);

extern int xfs_buf_iorequest(xfs_buf_t *);

extern int xfs_buf_iowait(xfs_buf_t *);

extern void xfs_buf_iomove(xfs_buf_t *, size_t, size_t, xfs_caddr_t,

extern void xfs_buf_iomove(xfs_buf_t *, size_t, size_t, void *,

				xfs_buf_rw_t);



static inline int xfs_buf_iostrategy(xfs_buf_t *bp)