Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b99a4d53 authored by Dan Carpenter's avatar Dan Carpenter Committed by Vlad Yasevich
Browse files

sctp: cleanup: remove duplicate assignment 



This assignment isn't needed because we did it earlier already.

Also another reason to delete the assignment is because it triggers a
Smatch warning about checking for NULL pointers after a dereference.

Reported-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
parent 787a51a0

net/sctp/sm_make_chunk.c

+9 −14
Original line number Diff line number Diff line
@@ -419,10 +419,17 @@ struct sctp_chunk *sctp_make_init_ack(const struct sctp_association *asoc, 
	if (!retval)

		goto nomem_chunk;



	/* Per the advice in RFC 2960 6.4, send this reply to

	 * the source of the INIT packet.

	/* RFC 2960 6.4 Multi-homed SCTP Endpoints

	 *

	 * An endpoint SHOULD transmit reply chunks (e.g., SACK,

	 * HEARTBEAT ACK, * etc.) to the same destination transport

	 * address from which it received the DATA or control chunk

	 * to which it is replying.

	 *

	 * [INIT ACK back to where the INIT came from.]

	 */

	retval->transport = chunk->transport;



	retval->subh.init_hdr =

		sctp_addto_chunk(retval, sizeof(initack), &initack);

	retval->param_hdr.v = sctp_addto_chunk(retval, addrs_len, addrs.v);
@@ -461,18 +468,6 @@ struct sctp_chunk *sctp_make_init_ack(const struct sctp_association *asoc, 
	/* We need to remove the const qualifier at this point.  */

	retval->asoc = (struct sctp_association *) asoc;



	/* RFC 2960 6.4 Multi-homed SCTP Endpoints

	 *

	 * An endpoint SHOULD transmit reply chunks (e.g., SACK,

	 * HEARTBEAT ACK, * etc.) to the same destination transport

	 * address from which it received the DATA or control chunk

	 * to which it is replying.

	 *

	 * [INIT ACK back to where the INIT came from.]

	 */

	if (chunk)

		retval->transport = chunk->transport;



nomem_chunk:

	kfree(cookie);

nomem_cookie: