Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aeae4dca authored by Suman Tripathi's avatar Suman Tripathi Committed by Tejun Heo
Browse files

ahci_xgene: Fix the watermark threshold for the APM X-Gene SATA host controller driver. 



As per SATA IO specification, when Host sends HOLD, the device takes
about 20DW latency to reply to HOLDA. In some case, device doesn't
response to HOLDA over 20DW and causes FIFO goes into over flow
condition. Due to this condition, device enumerations fails with
those devices. This patch adjust the watermark FIFO by increasing
the FIFO depth from 0x16(default) to 0x30 to address this issue.

Signed-off-by: default avatarLoc Ho <lho@apm.com>
Signed-off-by: default avatarSuman Tripathi <stripathi@apm.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 09de99db

drivers/ata/ahci_xgene.c

+7 −0
Original line number Diff line number Diff line
@@ -67,6 +67,9 @@ 
#define PORTAXICFG			0x000000bc

#define PORTAXICFG_OUTTRANS_SET(dst, src) \

		(((dst) & ~0x00f00000) | (((u32)(src) << 0x14) & 0x00f00000))

#define PORTRANSCFG			0x000000c8

#define PORTRANSCFG_RXWM_SET(dst, src)		\

		(((dst) & ~0x0000007f) | (((u32)(src)) & 0x0000007f))



/* SATA host controller AXI CSR */

#define INT_SLV_TMOMASK			0x00000010
@@ -176,6 +179,10 @@ static void xgene_ahci_set_phy_cfg(struct xgene_ahci_context *ctx, int channel) 
	val = PORTAXICFG_OUTTRANS_SET(val, 0xe); /* Set outstanding */

	writel(val, mmio + PORTAXICFG);

	readl(mmio + PORTAXICFG); /* Force a barrier */

	/* Set the watermark threshold of the receive FIFO */

	val = readl(mmio + PORTRANSCFG);

	val = PORTRANSCFG_RXWM_SET(val, 0x30);

	writel(val, mmio + PORTRANSCFG);

}



/**