Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad774702 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sebastian Reichel
Browse files

compal-laptop: Fix leaking hwmon device 



The commit c2be45f0 ("compal-laptop: Use
devm_hwmon_device_register_with_groups") wanted to change the
registering of hwmon device to resource-managed version. It mostly did
it except the main thing - it forgot to use devm-like function so the
hwmon device leaked after device removal or probe failure.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: c2be45f0 ("compal-laptop: Use devm_hwmon_device_register_with_groups")
Cc: <stable@vger.kernel.org>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarDarren Hart <dvhart@linux.intel.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 0595439a

drivers/platform/x86/compal-laptop.c

+3 −3
Original line number Diff line number Diff line
@@ -1026,7 +1026,7 @@ static int compal_probe(struct platform_device *pdev) 
	if (err)

		return err;



	hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,

	hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev,

							   "compal", data,

							   compal_hwmon_groups);

	if (IS_ERR(hwmon_dev)) {