Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a997448c authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: ipw: fix interface-data memory leak in error path 



Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3eb55cc4

drivers/usb/serial/ipw.c

+2 −3
Original line number Diff line number Diff line
@@ -203,8 +203,7 @@ static int ipw_open(struct tty_struct *tty, struct usb_serial_port *port) 
	return 0;

}



/* fake probe - only to allocate data structures */

static int ipw_probe(struct usb_serial *serial, const struct usb_device_id *id)

static int ipw_attach(struct usb_serial *serial)

{

	struct usb_wwan_intf_private *data;
@@ -303,7 +302,7 @@ static struct usb_serial_driver ipw_device = { 
	.num_ports =		1,

	.open =			ipw_open,

	.close =		ipw_close,

	.probe =		ipw_probe,

	.attach =		ipw_attach,

	.release =		ipw_release,

	.port_probe =		usb_wwan_port_probe,

	.port_remove =		usb_wwan_port_remove,