Commit a6bb340d authored Jul 11, 2007 by Jens Axboe Committed by Greg Kroah-Hartman Jul 18, 2007

debugfs: remove rmdir() non-empty complaint



Hi,

This patch kills the pointless debugfs rmdir() printk() when called on a
non-empty directory. blktrace will sometimes have to call it a few times
when forcefully ending a trace, which polutes the log with pointless
warnings.

Rationale:

- It's more code to work-around this "problem" in the debugfs users, and
  you would have to add code to check for empty directories to do so (or
  assume that debugfs is using simple_ helpers, but that would be a
  layering violation).

- Other rmdir() implementations don't complain about something this
  silly.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 5bae7ac9

fs/debugfs/inode.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -345,11 +345,6 @@ void debugfs_remove(struct dentry *dentry)
		switch (dentry->d_inode->i_mode & S_IFMT) {
		case S_IFDIR:
		ret = simple_rmdir(parent->d_inode, dentry);
		if (ret)
		printk(KERN_ERR
		"DebugFS rmdir on %s failed : "
		"directory not empty.\n",
		dentry->d_name.name);
		break;
		case S_IFLNK:
		kfree(dentry->d_inode->i_private);