Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a56635a5 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

net/iucv: Add missing spin_unlock 

Add a spin_unlock missing on the error path.  There seems like no reason
why the lock should continue to be held if the kzalloc fail.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* spin_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* spin_unlock(E1,...);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 23ecc4bd

net/iucv/af_iucv.c

+1 −1
Original line number Diff line number Diff line
@@ -1619,7 +1619,7 @@ static void iucv_callback_rx(struct iucv_path *path, struct iucv_message *msg) 
save_message:

	save_msg = kzalloc(sizeof(struct sock_msg_q), GFP_ATOMIC | GFP_DMA);

	if (!save_msg)

		return;

		goto out_unlock;

	save_msg->path = path;

	save_msg->msg = *msg;