Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0cfa850 authored by David Daney's avatar David Daney Committed by David S. Miller
Browse files

netdev: octeon_mgmt: Fix race manipulating irq bits. 



Don't re-read the interrupt status register, clear the exact bits we
will be testing.

Signed-off-by: default avatarDavid Daney <ddaney@caviumnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4d30b801

drivers/net/octeon/octeon_mgmt.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -598,8 +598,7 @@ static irqreturn_t octeon_mgmt_interrupt(int cpl, void *dev_id) 
	mixx_isr.u64 = cvmx_read_csr(CVMX_MIXX_ISR(port));

	mixx_isr.u64 = cvmx_read_csr(CVMX_MIXX_ISR(port));





	/* Clear any pending interrupts */

	/* Clear any pending interrupts */

	cvmx_write_csr(CVMX_MIXX_ISR(port),

	cvmx_write_csr(CVMX_MIXX_ISR(port), mixx_isr.u64);

		       cvmx_read_csr(CVMX_MIXX_ISR(port)));

	cvmx_read_csr(CVMX_MIXX_ISR(port));

	cvmx_read_csr(CVMX_MIXX_ISR(port));





	if (mixx_isr.s.irthresh) {

	if (mixx_isr.s.irthresh) {