Commit 9f3191ae authored Jun 11, 2011 by Jan Kiszka Committed by Avi Kivity Jul 12, 2011

KVM: Fix off-by-one in overflow check of KVM_ASSIGN_SET_MSIX_NR



KVM_MAX_MSIX_PER_DEV implies that up to that many MSI-X entries can be
requested. But the kernel so far rejected already the upper limit.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent 1dda606c

virt/kvm/assigned-dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -617,7 +617,7 @@ static int kvm_vm_ioctl_set_msix_nr(struct kvm *kvm,
		if (adev->entries_nr == 0) {
		adev->entries_nr = entry_nr->entry_nr;
		if (adev->entries_nr == 0 \|\|
		adev->entries_nr >= KVM_MAX_MSIX_PER_DEV) {
		adev->entries_nr > KVM_MAX_MSIX_PER_DEV) {
		r = -EINVAL;
		goto msix_nr_out;
		}