Commit 9d7ac8be authored Dec 22, 2006 by Thomas Gleixner Committed by Linus Torvalds Dec 22, 2006

[PATCH] genirq: fix irq flow handler uninstall



The sanity check for no_irq_chip in __set_irq_hander() is unconditional on
both install and uninstall of an handler.  This triggers false warnings and
replaces no_irq_chip by dummy_irq_chip in the uninstall case.

Check only, when a real handler is installed.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Sylvain Munaut <tnt@246tNt.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent e903387f

kernel/irq/chip.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -517,8 +517,7 @@ __set_irq_handler(unsigned int irq, irq_flow_handler_t handle, int is_chained,

		if (!handle)
		handle = handle_bad_irq;

		if (desc->chip == &no_irq_chip) {
		else if (desc->chip == &no_irq_chip) {
		printk(KERN_WARNING "Trying to install %sinterrupt handler "
		"for IRQ%d\n", is_chained ? "chained " : "", irq);
		/*