Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cf766f6 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: wm9705: Cleanup printk usage 



Use dev_err() instead of printk(KERN_ERR. This is common practice and makes
it easy to find out which device generated the message. While we are at it
also align the error messages with the other AC'97 drivers.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f114040e

sound/soc/codecs/wm9705.c

+4 −4
Original line number Diff line number Diff line
@@ -300,6 +300,8 @@ static int wm9705_reset(struct snd_soc_codec *codec) 
			return 0; /* Success */

	}



	dev_err(codec->dev, "Failed to reset: AC97 link error\n");



	return -EIO;

}
@@ -317,10 +319,8 @@ static int wm9705_soc_resume(struct snd_soc_codec *codec) 
	u16 *cache = codec->reg_cache;



	ret = wm9705_reset(codec);

	if (ret < 0) {

		printk(KERN_ERR "could not reset AC97 codec\n");

	if (ret < 0)

		return ret;

	}



	for (i = 2; i < ARRAY_SIZE(wm9705_reg) << 1; i += 2) {

		soc_ac97_ops->write(codec->ac97, i, cache[i>>1]);
@@ -339,7 +339,7 @@ static int wm9705_soc_probe(struct snd_soc_codec *codec) 


	ret = snd_soc_new_ac97_codec(codec, soc_ac97_ops, 0);

	if (ret < 0) {

		printk(KERN_ERR "wm9705: failed to register AC97 codec\n");

		dev_err(codec->dev, "Failed to register AC97 codec\n");

		return ret;

	}